issue_comments: 272077913

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1198#issuecomment-272077913 https://api.github.com/repos/pydata/xarray/issues/1198 272077913 MDEyOklzc3VlQ29tbWVudDI3MjA3NzkxMw== 1217238 2017-01-12T05:12:53Z 2017-01-12T05:12:53Z MEMBER

Don't worry about #1087 -- I can rebase it. On Wed, Jan 11, 2017 at 8:54 PM Phillip Wolfram notifications@github.com wrote:

@shoyer https://github.com/shoyer, I just realized this might conflict with #1087 https://github.com/pydata/xarray/pull/1087. Do you foresee this causing problems and what order do you plan to merge this PR and

1087 https://github.com/pydata/xarray/pull/1087 (which obviously

predates this one...)? We are running into the snag with #463 https://github.com/pydata/xarray/issues/463 in our analysis and my personal preference would be to get some type of solution into place sooner than later. Thanks for considering this request.

Also, I'm not sure exactly the best way to test performance either. Could we potentially use something like the "toy" test cases for this purpose? Ideally we would have a test case with O(100) files to gain a clearer picture of the performance cost of this PR.

Please let me know what you want me to do with this PR-- should I clean it up in anticipation of a merge or just wait for now to see if there are extra things that need fixed via additional testing? Note I have the full scipy, h5netcdf and pynio implementations that can also be reviewed because they weren't available when you did your review yesterday.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1198#issuecomment-272075886, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1o6yrNYYulbAMkLTHaVKLQA0u3Kjks5rRbIEgaJpZM4LfwBQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   199900056