issue_comments: 271996986

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1198#issuecomment-271996986 https://api.github.com/repos/pydata/xarray/issues/1198 271996986 MDEyOklzc3VlQ29tbWVudDI3MTk5Njk4Ng== 1217238 2017-01-11T21:16:35Z 2017-01-11T21:16:35Z MEMBER

Does that mean if the checks pass the code is at least minimally correct in terms of not breaking previous design choices? E.g., does this imply that we are ok except for cleanup / implementation details on this PR?

If the checks pass, it means that it doesn't directly break anything that we have tests for. Which should cover most functionality. However, we'll still need to be careful not to introduce performance regressions -- we don't have any automated performance tests yet.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   199900056