issue_comments: 269556898

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1171#issuecomment-269556898 https://api.github.com/repos/pydata/xarray/issues/1171 269556898 MDEyOklzc3VlQ29tbWVudDI2OTU1Njg5OA== 10050469 2016-12-28T23:17:02Z 2016-12-28T23:17:02Z MEMBER

@shoyer

if neither are set, then perhaps we should differ to whatever matplotlib defaults to

AFAIK, there is no logic for nlevels=int in mpl. Furthermore, mpl uses vmin and vmax to clip the data (not to decide upon the levels), which is undesirable for us.

However, the default mpl behavior when no levels are set is to call the private method _autolev which has a logic based on MaxNLocator too.

Long story short: I'll start another PR to address this problem specifically and then go back to MPL2 later on.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   196278181