issue_comments: 268927305

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1162#issuecomment-268927305 https://api.github.com/repos/pydata/xarray/issues/1162 268927305 MDEyOklzc3VlQ29tbWVudDI2ODkyNzMwNQ== 743508 2016-12-23T01:42:03Z 2016-12-23T01:42:03Z CONTRIBUTOR

@shoyer I'm down to 1 test failing locally in sel_points but not sure what the desired behaviour is. I get:

<xarray.Dataset> Dimensions: (points: 3) Coordinates: * points (points) int64 0 1 2 Data variables: foo (points) int64 0 4 8 instead of

AssertionError: <xarray.Dataset> Dimensions: (points: 3) Coordinates: o points (points) - Data variables: foo (points) int64 0 4 8

But here I'm not sure if my code is wrong or the test. It seems that the test requires sel_points NOT to generate a new coordinate values for points - however I'm pretty sure isel_points does require this (it passes in any case). Don't really see a way in my code to generate subsets without having a matching coordinate array (I don't know how to use the Dataset constructors without one for instance).

I've updated the test according to how I think it should be working, but please correct me if i misunderstood.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   195125296