issue_comments: 268597648

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1177#issuecomment-268597648 https://api.github.com/repos/pydata/xarray/issues/1177 268597648 MDEyOklzc3VlQ29tbWVudDI2ODU5NzY0OA== 1217238 2016-12-21T18:10:21Z 2016-12-21T18:10:21Z MEMBER

On master, I see: ``` In [5]: x = xr.DataArray([1, 2, 3], dims=('a',), coords={'a': [1, 2, 3]}, name='a')

In [6]: x Out[6]: <xarray.DataArray 'a' (a: 3)> array([1, 2, 3]) Coordinates: * a (a) int64 1 2 3

In [7]: x.rename({'a': 'b'}) Out[7]: <xarray.DataArray 'b' (b: 3)> array([1, 2, 3]) Coordinates: * b (b) int64 1 2 3 ```

So it renames both x and it's coordinate.

I agree that this is inconsistent and surprising. Using a dictionary should never rename the name of a DataArray. This is an inadvertent legacy of the previous (outdated) design of the DataArray class, which used a Dataset for holding its contents.

A fix for this would be very welcome.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   196984274