home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 263470325

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/798#issuecomment-263470325 https://api.github.com/repos/pydata/xarray/issues/798 263470325 MDEyOklzc3VlQ29tbWVudDI2MzQ3MDMyNQ== 306380 2016-11-29T04:02:05Z 2016-11-29T04:02:05Z MEMBER

A lock on the LRU cache makes sense to me.

We need separate, per file locks, to ensure that we don't evict files in the process of reading or writing data from them (which would cause segfaults). As a stop-gap measure, we could simply refuse to evict files until we can acquire a lock, but more broadly this suggests that strict LRU is not quite right. Instead, we want to evict the least-recently-used unlocked item

If it were me I would just block on the evicted file until it becomes available (the stop-gap measure) until it became a performance problem.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  142498006
Powered by Datasette · Queries took 0.735ms · About: xarray-datasette