home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 263344764

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1128#issuecomment-263344764 https://api.github.com/repos/pydata/xarray/issues/1128 263344764 MDEyOklzc3VlQ29tbWVudDI2MzM0NDc2NA== 1217238 2016-11-28T18:00:38Z 2016-11-28T18:00:38Z MEMBER

OK, I'm ready to give up on the remaining test failures and merge this anyways (marking them as expected failures). They are specific to our test suite and for Windows only, due to the inability to delete files that are not closed.

If these manifest themselves as issues for real users, I am happy to revisit, especially if someone who uses Windows can help debug. The 5 minute feedback cycle of pushing a commit and then seeing what Appveyor says is too painful.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  189817033
Powered by Datasette · Queries took 159.55ms · About: xarray-datasette