issue_comments: 262286432

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1132#issuecomment-262286432 https://api.github.com/repos/pydata/xarray/issues/1132 262286432 MDEyOklzc3VlQ29tbWVudDI2MjI4NjQzMg== 1217238 2016-11-22T16:17:51Z 2016-11-22T16:17:51Z MEMBER

Thanks for looking into this!

Based on how factorize works (with specialized handling for pandas dtypes), I think the most robust behavior would be to pass in a pandas.Index. For example, this will work better if someone uses a pandas.PeriodIndex. So I would suggest wrapping arrays with safe_cast_to_index before passing them to pd.factorize.

I'm not sure if we want a .view attribute on DataArrays, but in any case it's not clear that would even fix the issue here -- pandas probably needs to a coerce to numpy arrays internally in factorize eventually anyways.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   190683531