home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 261599007

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1130#issuecomment-261599007 https://api.github.com/repos/pydata/xarray/issues/1130 261599007 MDEyOklzc3VlQ29tbWVudDI2MTU5OTAwNw== 1217238 2016-11-18T18:03:06Z 2016-11-18T18:03:06Z MEMBER

But maybe_wrap_array is simple and does not break anything, it wraps it only when it's safe.

It's safe in the sense that the xarray.DataArray contains the information from the numpy array, but it's not safe in terms of a stable type signature.

I think that could be quite likely as one might want to apply a DataArray-compatible function. This would force users to remember which type of "function applier" to use for a given function and might be confusing.

I think this is unavoidable. It's impossible to design a single entry point that works smoothly for both use cases.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  189998469
Powered by Datasette · Queries took 0.784ms · About: xarray-datasette