home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 261496603

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1130#issuecomment-261496603 https://api.github.com/repos/pydata/xarray/issues/1130 261496603 MDEyOklzc3VlQ29tbWVudDI2MTQ5NjYwMw== 941907 2016-11-18T10:16:17Z 2016-11-18T10:16:17Z NONE

... rather not adjust DataArray.pipe, which is intentionally very simple.

It would be just one extra call to a funciton which is very simple. As I commented in #1074, I think it makes more sense to have pipe wrap arrays, because otherwise the pipe-chain might get broken, whereas with apply I'd be ok with it behaving as the python apply function which simply applies a function and nothing more. But maybe_wrap_array is simple and does not break anything, it wraps it only when it's safe.

In the unlikely event your function takes a dim argument

I think that could be quite likely as one might want to apply a DataArray-compatible function. This would force users to remember which type of "function applier" to use for a given function and might be confusing.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  189998469
Powered by Datasette · Queries took 0.648ms · About: xarray-datasette