issue_comments: 261198288

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1080#issuecomment-261198288 https://api.github.com/repos/pydata/xarray/issues/1080 261198288 MDEyOklzc3VlQ29tbWVudDI2MTE5ODI4OA== 10050469 2016-11-17T09:32:59Z 2016-11-17T09:32:59Z MEMBER

Sorry for chiming in here. Using the example above, if we have the choice between: 1) sig.lowpass(0.2).multiply(3) 2) sig.accessorlib.lowpass(0.2).multiply(3) 3) sig.pipe(xdsp.lowpass, 0.2).pipe(np.multiply, 3) 4) sig(xdsp.lowpass, 0.2)(np.multiply, 3)

Of course, (1) is attractive because straight forward (as the dev of a small xarray accessor, I also forget very often that I have to add an attribute between the dataset and my function call). But (2) has the huge advantage that it clearly says where the code of the function is found, and where to ask questions when things do not work as expected.

(3) is OK for me since it is very explicit, but I find that (4) is quite ugly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   187373423