issue_comments: 259757652

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1065#issuecomment-259757652 https://api.github.com/repos/pydata/xarray/issues/1065 259757652 MDEyOklzc3VlQ29tbWVudDI1OTc1NzY1Mg== 1217238 2016-11-10T17:45:11Z 2016-11-10T17:45:11Z MEMBER

My concern is how this setting currently does not change how we join variables in Dataset math. Consider the current behavior -- it always does an inner join of the data variables:

``` In [2]: import xarray as xr

In [3]: ds1 = xr.Dataset({'foo': 1, 'bar': 2})

In [4]: ds2 = xr.Dataset({'bar': 2, 'baz': 3})

In [5]: ds1 Out[5]: <xarray.Dataset> Dimensions: () Coordinates: empty Data variables: bar int64 2 foo int64 1

In [6]: ds2 Out[6]: <xarray.Dataset> Dimensions: () Coordinates: empty Data variables: bar int64 2 baz int64 3

In [7]: ds1 + ds2 Out[7]: <xarray.Dataset> Dimensions: () Coordinates: empty Data variables: bar int64 4 ```

Logically, it makes sense for this option to switch this to an outer join instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   185794232