home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 259202265

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/798#issuecomment-259202265 https://api.github.com/repos/pydata/xarray/issues/798 259202265 MDEyOklzc3VlQ29tbWVudDI1OTIwMjI2NQ== 1217238 2016-11-08T17:27:55Z 2016-11-08T22:19:11Z MEMBER

A few other thoughts on thread safety with the LRU approach: 1. We need to a global lock ensure internal consistency of the LRU cache, and so that we don't overwrite files without closing them. It probably makes sense to put this in memoize function. 2. We need separate, per file locks, to ensure that we don't evict files in the process of reading or writing data from them (which would cause segfaults). As a stop-gap measure, we could simply refuse to evict files until we can acquire a lock, but more broadly this suggests that strict LRU is not quite right. Instead, we want to evict the least-recently-used unlocked item.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  142498006
Powered by Datasette · Queries took 0.766ms · About: xarray-datasette