issue_comments: 258887083

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1028#issuecomment-258887083 https://api.github.com/repos/pydata/xarray/issues/1028 258887083 MDEyOklzc3VlQ29tbWVudDI1ODg4NzA4Mw== 4160723 2016-11-07T16:37:03Z 2016-11-07T16:37:03Z MEMBER

Just committed review changes.

.reset_index() doesn't accept kwargs anymore, though I don't know what to choose between the options below (currently option A is implemented): - option A: reset_index(dim, levels=None) where dim may accept multiple dimension names (in that case levels must be a list of lists with the same length than dim, or simply None that would then be applied to all given dimensions). - option B: same than option A, reset_index(dim, levels=None), except that dim only accepts one dimension (thus a bit simpler but less flexible). - option C: reset_index(dim_or_levels) where one can provide a list of dimension(s) and/or level(s). This is the most flexible and concise, though maybe less readable. Allow providing both dimensions and levels may be ambiguous too.

if x is a normal (non-multi) Index, array.reset_index('x') is not well defined

Currently .reset_index() doesn't allow resetting normal indexes, but we can wait for #1017 before merging this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   180638999