issue_comments: 257061634

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1065#issuecomment-257061634 https://api.github.com/repos/pydata/xarray/issues/1065 257061634 MDEyOklzc3VlQ29tbWVudDI1NzA2MTYzNA== 1217238 2016-10-29T01:10:18Z 2016-10-29T01:10:18Z MEMBER

It occurs to me now that the other reason why people avoid global variables is because of concerns around thread safety and distributed computation. Even with the context manager, bad things will happen if you use set_options simultaneously from different threads.

I need to think about this a little more. Copious warnings in the docs might be enough, or maybe entering a set_options context should also enter an explicit threading.Lock() context.

On the other hand, the current implementation is basically identical to how functionality like NumPy's np.errstate() works, and people seem to be pretty happy with that.

@mrocklin does this seem like the sort of change we can do in xarray without seriously regretting it later? Xarray uses basically the same set_options machinery that dask has.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   185794232