home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 251209654

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1024#issuecomment-251209654 https://api.github.com/repos/pydata/xarray/issues/1024 251209654 MDEyOklzc3VlQ29tbWVudDI1MTIwOTY1NA== 6213168 2016-10-03T19:58:53Z 2016-10-03T20:31:48Z MEMBER

What happened before this PR was that all coords were blindly converted to dask on chunk(). Then, the first time anything invoked the values property, e.g. Something as simple as DataArray.__str__., they were silently converted back to numpy. It wasn't easy to accidentally get them in dask format; in fact no unit test noticed before my last commit.

If you deliberately use a dask array as a coord, it won't be converted to numpy. However I can't think of any reason why anybody would want to do it in practice. I'll add it to the breaking changes as if somebody did do the above, the performance of his program will degrade with this release as his coord will risk being evaluated multiple times.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  180451196
Powered by Datasette · Queries took 0.491ms · About: xarray-datasette