home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 251013933

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1027#issuecomment-251013933 https://api.github.com/repos/pydata/xarray/issues/1027 251013933 MDEyOklzc3VlQ29tbWVudDI1MTAxMzkzMw== 1197350 2016-10-03T02:16:27Z 2016-10-03T02:17:24Z MEMBER

@shoyer So do you want the keyword argument dropped altogether? Or just the default changed (as in my last commit)?

I can imagine wanting to drop the empty bins in some cases, but not as default. So I would vote to keep the keyword argument.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  180536861
Powered by Datasette · Queries took 77.28ms · About: xarray-datasette