issue_comments: 248946179

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1007#issuecomment-248946179 https://api.github.com/repos/pydata/xarray/issues/1007 248946179 MDEyOklzc3VlQ29tbWVudDI0ODk0NjE3OQ== 1217238 2016-09-22T15:56:47Z 2016-09-22T15:56:47Z MEMBER

Might the docstring for auto_combine need to be updated? Currently it seems to suggest that sorting, alignment and the addition of new data variables are not supported, whereas I think all these can occur with compat='no_conflicts'.

Yep, with compat='no_conflicts' and recent align updates to concat, we are most of the way there on alignment.

It still can fail if there are different variables on datasets across the concatenated dimension, but that will be fixed when we get concat to handle different variables (#508). At that point, we might want to switch the logic from the current "concatenate by variable group, then merge" to "merge by unique coordinates, then concatenate".

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   177689088