issue_comments: 248798053

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/964#issuecomment-248798053 https://api.github.com/repos/pydata/xarray/issues/964 248798053 MDEyOklzc3VlQ29tbWVudDI0ODc5ODA1Mw== 1217238 2016-09-22T02:57:29Z 2016-09-22T02:57:29Z MEMBER

@chris-b1 thanks for giving this is a try! Using this with numba's guvectorize is exactly what I had in mind.

1) Yes, we need a better error here.

2) Agreed, it's really hard to parse a triply nested list. I don't like encouraging writing signature strings though because that artificially restricts dimensions to use strings (and it's weird to program in strings).

Maybe separate arguments for input_core_dims and output_core_dims would make more sense, e.g., xr.apply(std_gufunc, arr, input_core_dims=[('x',)])?

3) Yes, agreed. The main issue with xr.apply(std_gufunc, arr, dims=('x',)) is that it's not clear what that means if std_gufunc is not a gufunc. For example, one might expect it to generate axis arguments.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   170779798