home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 248171030

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1008#issuecomment-248171030 https://api.github.com/repos/pydata/xarray/issues/1008 248171030 MDEyOklzc3VlQ29tbWVudDI0ODE3MTAzMA== 1217238 2016-09-20T00:48:01Z 2016-09-20T00:48:01Z MEMBER

OK, that makes sense. I agree, we could keep such arrays as float32. We don't need to guard against overflow when only decoding a _FillValue.

If you're interested in taking a look at a fix, this is where the current logic is: https://github.com/pydata/xarray/blob/551a7bca7b42a6d6db976b01d2eee1131735785d/xarray/conventions.py#L795-L802

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  177754433
Powered by Datasette · Queries took 0.682ms · About: xarray-datasette