home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 246560535

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/996#issuecomment-246560535 https://api.github.com/repos/pydata/xarray/issues/996 246560535 MDEyOklzc3VlQ29tbWVudDI0NjU2MDUzNQ== 1217238 2016-09-13T03:07:11Z 2016-09-13T03:07:11Z MEMBER

I think this is nearly ready. We just need to decide on the final keyword name (e.g., notnull_equals or no_conflicts) and add mention of this in the documentation / what's new.

I'm not sure we really need this new method for Dataset/DataArray (for the current implementation, adding it on Variable would be enough). Given that the user can catch MergeError, it seems straightforward enough just call merge to see if merging is safe.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  174404136
Powered by Datasette · Queries took 0.767ms · About: xarray-datasette