home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 244142205

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/947#issuecomment-244142205 https://api.github.com/repos/pydata/xarray/issues/947 244142205 MDEyOklzc3VlQ29tbWVudDI0NDE0MjIwNQ== 1217238 2016-09-01T16:55:12Z 2016-09-01T16:55:12Z MEMBER

Should I write new tests specific to multi-index or should I modify existing tests (e.g., TestDataset.test_modify_inplace, TestDataset.tes_coord_properties, TestDataset.test_coords_modify, etc.) to include the multi-index case?

I would usually lean towards dedicated tests (e.g., test_modify_multiindex_inplace) but if it's easier to modify the original tests in a small way (e.g., for repr) feel free to take that approach

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  169588316
Powered by Datasette · Queries took 0.855ms · About: xarray-datasette