issue_comments: 243962394
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/996#issuecomment-243962394 | https://api.github.com/repos/pydata/xarray/issues/996 | 243962394 | MDEyOklzc3VlQ29tbWVudDI0Mzk2MjM5NA== | 1217238 | 2016-09-01T02:57:21Z | 2016-09-01T02:57:21Z | MEMBER | This is quite clever! I'm impressed this was so easy using One potential concern here is that performance is not going to be so great if you attempt to combine a bunch of variables with lazy data loaded with dask, because each comparison will trigger a separate computation. To that end, it would be nice to do the safety check in a single dask operation. To be fair, this is already an issue if you're trying to merge lots of datasets together. But I expect this will become more of an issue when there are useful ways to merge a bunch of datasets, which is what this PR enables. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
174404136 |