issue_comments: 243948268

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/990#issuecomment-243948268 https://api.github.com/repos/pydata/xarray/issues/990 243948268 MDEyOklzc3VlQ29tbWVudDI0Mzk0ODI2OA== 1217238 2016-09-01T01:10:56Z 2016-09-01T01:10:56Z MEMBER

The easiest fix would be to add a decorator to skip tests on Windows, like the existing decorators that we use: https://github.com/pydata/xarray/blob/master/xarray/test/init.py#L73

I'm not sure off hand how to detect if we're running on Windows but it can't be hard.

To add a close method, I would copy these lines from dataset.py (or better use, move them to the common base class BaseDataObject in common.py): https://github.com/pydata/xarray/blob/master/xarray/core/dataset.py#L251-L262

Then, you just need to define _file_obj = None in DataArray.__init__ and set it when appropriate.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   173632183