home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 243933961

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/991#issuecomment-243933961 https://api.github.com/repos/pydata/xarray/issues/991 243933961 MDEyOklzc3VlQ29tbWVudDI0MzkzMzk2MQ== 296686 2016-08-31T23:32:56Z 2016-08-31T23:32:56Z CONTRIBUTOR

I think I've dealt with all of these.

Refactoring the tests has made them a bit cleaner and safer due to not using mutation - however I still have quite a few repeated lines of code. I've also combined them all into one test with lots of asserts - as otherwise I couldn't keep the helper functions within the test without repeating them loads of times.

Does anything need adding to the docs for this? I'm assuming not as it's just making the code do more checking, it's not adding a feature as such?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  173640823
Powered by Datasette · Queries took 0.716ms · About: xarray-datasette