issue_comments: 243007936

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/990#issuecomment-243007936 https://api.github.com/repos/pydata/xarray/issues/990 243007936 MDEyOklzc3VlQ29tbWVudDI0MzAwNzkzNg== 1217238 2016-08-29T00:00:46Z 2016-08-29T00:00:46Z MEMBER

I would add these tests to test_backends, probably a new test class. The best test is probably a round-trip test where we save and load a DataArray and verify that the result is identical to what we started with. On Sun, Aug 28, 2016 at 2:20 PM Robin Wilson notifications@github.com wrote:

Thanks @shoyer https://github.com/shoyer - I wasn't actually aware that DataArrays can have a name before they're put into a Dataset (that's one of the things I love about contributing to OSS: you always learn things about the software that you never knew before!). I'll deal with the design issues ASAP.

How would you suggest testing this? I wasn't sure where to put the tests, and what exactly to test? Presumably something about the equivalence between this and saving after manually converting to a dataset, but I wasn't really sure how best to go about it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/990#issuecomment-243000159, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1qbgrUqpkuRNqP4BjhclA25MrRN-ks5qkfusgaJpZM4Ju3Aq .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   173632183