issue_comments: 242996578

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/990#issuecomment-242996578 https://api.github.com/repos/pydata/xarray/issues/990 242996578 MDEyOklzc3VlQ29tbWVudDI0Mjk5NjU3OA== 1217238 2016-08-28T20:15:21Z 2016-08-28T20:15:21Z MEMBER

I'm also a little concerned about the design here, because it always saves/restores the DataArray with the name 'data', which could override the original name. Ideally this method should save/restore a DataArray as faithfully as possible.

Instead, maybe we should only override the original name if it's None, or the same name as one of it's coordinates (which would otherwise result in an invalid NetCDF file).

Then we could restore by looking for a Dataset with single data variable regardless of the name, e.g.,

if len(dataset.data_vars) != 1: raise ValueError data_array, = dataset.data_vars.values()

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   173632183