home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 241578398

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/975#issuecomment-241578398 https://api.github.com/repos/pydata/xarray/issues/975 241578398 MDEyOklzc3VlQ29tbWVudDI0MTU3ODM5OA== 10194086 2016-08-22T23:07:50Z 2016-08-22T23:07:50Z MEMBER

As somewhat hinted at above there seem to be several issues here. I tried to look into a solution for checking the first and last element (which seems work for Problem (1) in my original post) but the OverflowError persisted so I looked into this and now my code is a mess but I figured this second problem out.

Pandas does not raise an overflow error when adding a TimedeltaIndex and a Timestamp.

``` import pandas as pd

overflow error

pd.to_timedelta(106580, 'D') + pd.Timestamp('2000')

no overflow error

pd.to_timedelta([106580], 'D') + pd.Timestamp('2000') ```

This screws up line 145 in https://github.com/pydata/xarray/blob/master/xarray/conventions.py.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  171956399
Powered by Datasette · Queries took 0.768ms · About: xarray-datasette