issue_comments: 238050009
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/947#issuecomment-238050009 | https://api.github.com/repos/pydata/xarray/issues/947 | 238050009 | MDEyOklzc3VlQ29tbWVudDIzODA1MDAwOQ== | 1217238 | 2016-08-06T21:35:24Z | 2016-08-06T21:35:24Z | MEMBER | This is very exciting to see! A few thoughts on implementation: Instead of always creating a dictionary of level coordinates, I would add an attribute It's much cheaper to call ``` In [12]: idx = pd.MultiIndex.from_product([np.linspace(0, 1, num=500), np.arange(1000)]) In [13]: %timeit idx.get_level_values(0)[:10] 1000 loops, best of 3: 1.28 ms per loop In [14]: %timeit idx[:10].get_level_values(0) 10000 loops, best of 3: 101 µs per loop ``` It's even more extreme for larger indexes. If possible, we should use something closer to this approach when formatting coordinates.
I would actually be happy to disallow both, which might be even easy. It seems like a fine rule to say that you cannot call |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
169588316 |