home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 237649523

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/940#issuecomment-237649523 https://api.github.com/repos/pydata/xarray/issues/940 237649523 MDEyOklzc3VlQ29tbWVudDIzNzY0OTUyMw== 950575 2016-08-04T18:57:14Z 2016-08-04T18:57:14Z CONTRIBUTOR

Decoding time units into timedelta64 is useful if you want to be able to use them for arithmetic with datetimes.

I get that but my question is how often do users perform do such operations? Again I am biased b/c with my data I never want to do that as it does not make sense. And, when it does make sense, I believe that the price of post conversion is worth the advantages of converting by default.

Still I'm somewhat reluctant to change the default here.

If you want decode_timedeltas=True as the default I am not sure it is worth the extra keyword then. My goal with this PR is to avoid extra steps. If users need to set it to True it is not too different from doing data.values / 1e9. If all we get is to change one step for another I prefer to not make the open_dataset more complex and leave it as is.

Feel free to close this. I don't have strong feelings about what xarray should do by default. I just want to make it more convenient for my uses cases.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  169276671
Powered by Datasette · Queries took 0.779ms · About: xarray-datasette