issue_comments: 236988451

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/844#issuecomment-236988451 https://api.github.com/repos/pydata/xarray/issues/844 236988451 MDEyOklzc3VlQ29tbWVudDIzNjk4ODQ1MQ== 950575 2016-08-02T18:00:19Z 2016-08-02T18:00:19Z CONTRIBUTOR

I fine with whatever you decide but here are my two cents: - get_variables_by_attributes is the same name of this method in netcd4 and some java netcdf libraries. So I'd rather not have a specialized version for attributes than adding it with name with a different name. - I see the elegance in s.filter(lambda x: x.attrs['standard_name'] == 'convective_precipitation_flux') and I like it a lot! But the specialized version for attributes is more compact to write and, at least in my field, filtering by attributes is more common making this version more convenient.

Feel free to close this if you don't think it is worth adding the specialized version. Or let me know if you want to rename it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   153126324