issue_comments: 236986387

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/844#issuecomment-236986387 https://api.github.com/repos/pydata/xarray/issues/844 236986387 MDEyOklzc3VlQ29tbWVudDIzNjk4NjM4Nw== 1217238 2016-08-02T17:53:45Z 2016-08-02T17:53:45Z MEMBER

@ocefpaf Good point. It probably is indeed better to write be able to write something generic like ds.filter(lambda x: x.attrs['standard_name'] == 'convective_precipitation_flux') rather the specialized to attributes ds.get_variables_by_attributes(standard_name='convective_precipitation_flux').

Another option would be simply renaming this to filter_attrs, which is more succinct.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   153126324