issue_comments: 233201657

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/637#issuecomment-233201657 https://api.github.com/repos/pydata/xarray/issues/637 233201657 MDEyOklzc3VlQ29tbWVudDIzMzIwMTY1Nw== 1217238 2016-07-17T20:17:49Z 2016-07-17T20:17:49Z MEMBER

@robintw The challenge is that we want to handle aspect consistently even if we're doing a multi-faceted plot. Right now, we use the opposite convention (to matplotlib) for multi-faceted plots. So either: 1. We change the existing behavior for muilt-panel plots (and become inconsistent with Seaborn). 2. We change the existing behavior of aspect for single panel plots (and become inconsistent with matplotlib).

I would lean toward (2), currently implemented in this PR given that I think aspect is used more often for muilt-panel plots, but I'm OK with either option. If we pick (1), then we'll need to adjust both this PR and the existing behavior for multi-panel plots.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   112928260