issue_comments: 223999761

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/818#issuecomment-223999761 https://api.github.com/repos/pydata/xarray/issues/818 223999761 MDEyOklzc3VlQ29tbWVudDIyMzk5OTc2MQ== 1217238 2016-06-06T15:45:49Z 2016-06-06T15:45:49Z MEMBER

Empty groups should be straightforward -- we should be able handle them.

Indices which don't belong to any group are indeed more problematic. I think we have three options here: 1. Raise an error when calling .groupby_bins(...) 2. Raise an error when calling .groupby_bins(...).apply(...) 3. Simply concatenate back together whatever items were grouped, and give up on the guarantee that the applying the identity function restores the original item.

I think my preference would be for option 3, though 1 or 2 could be reasonable work arounds for now (raising NotImplementedError), because 3 is likely to be a little tricky to implement.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   146182176