issue_comments: 219875456

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/818#issuecomment-219875456 https://api.github.com/repos/pydata/xarray/issues/818 219875456 MDEyOklzc3VlQ29tbWVudDIxOTg3NTQ1Ng== 2443309 2016-05-17T22:38:56Z 2016-05-17T22:38:56Z MEMBER

@rabernat - I just had a look through the code and it looks pretty good. I have a few broader questions though: 1. You have a few outstanding todo items from the first comment in your PR:

  • [ ] Allow specification of which dims to stack. For example, stack in space but keep time dimension intact. (Currently it just stacks all the dimensions of the group variable.)
  • [ ] A nice example for the docs.

Where do we stand on these? You have some simple examples in the docs now but maybe you were thinking of more complete examples? 2. In https://github.com/pydata/xarray/pull/818#issuecomment-218358050, I ran into the index is monotonic issue, it sounds like that was resolved. Do we cover that case in a test?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   146182176