issue_comments: 219189254

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/401#issuecomment-219189254 https://api.github.com/repos/pydata/xarray/issues/401 219189254 MDEyOklzc3VlQ29tbWVudDIxOTE4OTI1NA== 1217238 2016-05-14T00:34:14Z 2016-05-14T00:34:14Z MEMBER

Yes, I still think that makes sense. I don't like issuing warnings other than for deprecation cycles. On Fri, May 13, 2016 at 5:29 PM Joe Hamman notifications@github.com wrote:

@shoyer https://github.com/shoyer - reading back in this thread (#401 (comment) https://github.com/pydata/xarray/pull/401#issuecomment-96085330) you mentioned moving this fix to conventions.py and writing a dtype: bool attribute for bool typed variables. Do you still think that makes since?

Alternatively, we could just raise a warning when typecasting on write. This is the lazy but less intrusive way of operating.

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/pydata/xarray/pull/401#issuecomment-219188897

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   70805273