home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 218362023

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/817#issuecomment-218362023 https://api.github.com/repos/pydata/xarray/issues/817 218362023 MDEyOklzc3VlQ29tbWVudDIxODM2MjAyMw== 1217238 2016-05-11T04:59:16Z 2016-05-11T04:59:16Z MEMBER

I am reluctant to merge this without having any way to test the logic. Without automated tests this issue is likely to recur.

That said, I suppose we could leave the refactoring for a TODO. Let's add a note on that and also one minimal test to verify that we raise an error if you try to use engine='netcdf4' with a path to local gzipped file.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  146079798
Powered by Datasette · Queries took 0.772ms · About: xarray-datasette