issue_comments: 218304910

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/650#issuecomment-218304910 https://api.github.com/repos/pydata/xarray/issues/650 218304910 MDEyOklzc3VlQ29tbWVudDIxODMwNDkxMA== 10194086 2016-05-10T22:00:35Z 2016-05-10T22:00:35Z MEMBER

I could imagine to continue working on this - however, there are some open design questions: - Do we include skipna? (I would say yes) - Do we allow the weights to contain NaN? (I would say yes, although disallowing it would make it easier.) - Does skipna also apply to the weights or are NaNs always skipped in the weights? (I would suggest the latter.) - Do we need a skipna_weights for a fine grained control of this? (This sounds unnecessary) - Do you agree with the above given examples?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   115933483