issue_comments: 217132574
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/844#issuecomment-217132574 | https://api.github.com/repos/pydata/xarray/issues/844 | 217132574 | MDEyOklzc3VlQ29tbWVudDIxNzEzMjU3NA== | 950575 | 2016-05-05T11:41:19Z | 2016-05-05T11:41:19Z | CONTRIBUTOR |
I thought a little bit more about this and now I am on the fence. The pros of filtering only data variables are a nice and clean Dataset object, and overall consistency with the high level xarray model. The cons are that we cannot do the filtering on the coords (obviously), but most of the time that we need to do that we go to a lower level object like I am 51% with filtering both (and the current implementation does that) but I will leave the final decision to you. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
153126324 |