issue_comments: 210701860
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/issues/825#issuecomment-210701860 | https://api.github.com/repos/pydata/xarray/issues/825 | 210701860 | MDEyOklzc3VlQ29tbWVudDIxMDcwMTg2MA== | 12307589 | 2016-04-16T01:06:27Z | 2016-04-16T01:06:27Z | CONTRIBUTOR | @shoyer the default keep_attrs isn't the problem here, the issue is that there is currently no keep_attrs option at all for resampling. I've implemented a solution, but now test TestDataset.test_resample_and_first is failing. This is because for how="first" and how="last", attributes are currently kept (keep_attrs=True). This may break some code if resample is given a default of keep_attrs=False. Using a default of keep_attrs=True for how in ('first', 'last') results in the test passing. Alternatively I could make it so the default behavior is to not pass any keep_attrs value on to the grouper function, which would keep the current defaults of those groupers. The code would be a bit uglier but it's not hard, and it would prevent breaking scripts. What do we want for the default behavior? |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
148765426 |