home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 210629679

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/824#issuecomment-210629679 https://api.github.com/repos/pydata/xarray/issues/824 210629679 MDEyOklzc3VlQ29tbWVudDIxMDYyOTY3OQ== 4295853 2016-04-15T20:24:31Z 2016-04-15T20:24:31Z CONTRIBUTOR

@shoyer, is this related to https://github.com/pydata/xarray/pull/800? If I recall correctly based on https://github.com/pydata/xarray/issues/793 there may be some issues with dask/multithreading without the lock. Am I missing something here?

It may make sense to just to set lock=False by default in https://github.com/pydata/xarray/blob/master/xarray/backends/api.py#L247 and if issues are encountered lock=True can be set by the user. Is this what you are thinking? If so, I can submit the super simple PR if that is helpful.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  148757289
Powered by Datasette · Queries took 0.709ms · About: xarray-datasette