home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 203468065

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/808#issuecomment-203468065 https://api.github.com/repos/pydata/xarray/issues/808 203468065 MDEyOklzc3VlQ29tbWVudDIwMzQ2ODA2NQ== 2443309 2016-03-30T14:46:49Z 2016-03-30T14:46:49Z MEMBER

Setuptools has the concept of extras_require but the application doesn't really work with our optional import of bottleneck (ref). I think what may work here is to check the bottleneck version on import and raise a warning if the version is not sufficient for all the functionality we use it for.

So here may look something like:

Python try: import bottleneck as bn has_bottleneck = True if bn.__version__ < 1.0: warnings.warn('insufficient bottleneck version...') except ImportError: # use numpy methods instead bn = np has_bottleneck = False

Alternatively, we could raise an error or fall back to use the numpy methods.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  144575316
Powered by Datasette · Queries took 0.852ms · About: xarray-datasette