issue_comments: 195611382

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/791#issuecomment-195611382 https://api.github.com/repos/pydata/xarray/issues/791 195611382 MDEyOklzc3VlQ29tbWVudDE5NTYxMTM4Mg== 4295853 2016-03-12T00:09:15Z 2016-03-12T00:09:15Z CONTRIBUTOR

@shoyer, should a custom version supporting nans be implemented too? I think that is more useful for my immediate needs and it would be good to have both options for completeness. However, it will be somewhat of a hack and involve adding nancumsum and nancumprod functions to npcompat.py. Note, however, that these are not standard numpy functions, even in known future versions, so I'm concerned this change falls into the "hack" category. This being said, implementation of the standard numpy functions would still be useful and the nans case could be handled at the application level.

Can you provide some perspective on what you would be willing to admit into xarray? It seems like standard cumsum and cumprod are safe bets but the nan versions are somewhat suspect.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   140214928