home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 185365318

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/668#issuecomment-185365318 https://api.github.com/repos/pydata/xarray/issues/668 185365318 MDEyOklzc3VlQ29tbWVudDE4NTM2NTMxOA== 2443309 2016-02-17T19:28:05Z 2016-02-17T21:24:33Z MEMBER

@shoyer -

This could use another review from you. Failing tests have been fixed. There's a bunch more functionality that can be built out in future pull requests. This provides the basic rolling functionality we were going for.

One thing to note, with center=True, we differ from pandas in the last position in some instances. I made a note in my unit test that we're okay with that for now.

~~Lastly, this will need a squash and I'll do that once we're settled on the features.~~

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  120038291
Powered by Datasette · Queries took 0.66ms · About: xarray-datasette