issue_comments: 176869693
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/731#issuecomment-176869693 | https://api.github.com/repos/pydata/xarray/issues/731 | 176869693 | MDEyOklzc3VlQ29tbWVudDE3Njg2OTY5Mw== | 1217238 | 2016-01-29T17:20:50Z | 2016-01-29T17:20:50Z | MEMBER |
Nope, it can handle any eager (numpy) and lazy (dask) xarray objects. Something like this should work: ``` depending on exactly what syntax we supporteager = self.eager_array.tensordot(self.eager_array[0]) lazy = self.lazy_array.tensordot(self.lazy_array[0])) self.assertLazyAndAllClose(eager, lazy) ```
This is a good point! Arrays with redundant dimensions are not very useful. The sane thing to do is to broadcast over dimensions that aren't being summed That said, this is difficult to implement with numpy's dot/tensordot, so perhaps it's better to simply error or omit the I also wonder if perhaps we should rename this from |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
129286220 |