issue_comments: 176571428

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/731#issuecomment-176571428 https://api.github.com/repos/pydata/xarray/issues/731 176571428 MDEyOklzc3VlQ29tbWVudDE3NjU3MTQyOA== 15167171 2016-01-29T04:44:25Z 2016-01-29T04:45:45Z NONE

I've implemented all your comments, except: 1. In the dask test I'm having a little trouble with: self.assertLazyAndAllClose(eager, lazy) working with the DataArrays I make. Does it only take transformations of:

self.eager_array self.lazy_array

2 Your comment: Use the genetic type(self) instead Which I didn't understand.

3 Need to figure out how to edit the docs.

And I was thinking: The default (when no dims arg is given) should be to tensordot over all shared dims between DataArrays. And it should prevent you from not summing over all shared dims, since that will return a DataArray with repeated labels. I think it would be rare for people to want to tensor dot over different dimensions.

Thanks for all your help getting me going!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   129286220