home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 175394725

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/728#issuecomment-175394725 https://api.github.com/repos/pydata/xarray/issues/728 175394725 MDEyOklzc3VlQ29tbWVudDE3NTM5NDcyNQ== 1217238 2016-01-27T04:47:50Z 2016-01-27T04:47:50Z MEMBER

This was definitely caused by the refactor of DataArray internals in 0.7.0.

I don't think you were doing anything wrong, per se, it's just that the internal refactor changed what you can do with a subclasses in an unexpected way :(.

On the plus side, the new code should be better about preserving DataArray subclasses -- new DataArrays should be to the same type as parent objects. However, you will need to preserve the signature of DataArray.__init__, or replace the private _replace method on your subclass (I don't recommend this, because it's also definitely private API and not guaranteed to continue to work).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  128980804
Powered by Datasette · Queries took 0.721ms · About: xarray-datasette