home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 164040753

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/674#issuecomment-164040753 https://api.github.com/repos/pydata/xarray/issues/674 164040753 MDEyOklzc3VlQ29tbWVudDE2NDA0MDc1Mw== 5635139 2015-12-11T20:31:00Z 2015-12-11T20:31:00Z MEMBER

On reflection, I favor (1) pretty clearly. I don't have much experience with XRay, so I trust you more than I trust myself, but: - In our use cases, we care about exactly what the axes / coords are. So we need some single source of truth there. If I implemented this using the outer join, we wouldn't use it much! - I can't clearly visualize the use cases supporting the other side - where users have coords that they want to add 'in addition', but that aren't on a DataArray they're supplying. - I haven't heard of people being confused on the pandas index= parameter (although I'm absent from SO discussions etc, so may have missed them)

Let me know your thoughts. We should pick the right way, not the preference of the person implementing it, so chose what you think is best.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  121569683
Powered by Datasette · Queries took 0.57ms · About: xarray-datasette