home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 162031347

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/668#issuecomment-162031347 https://api.github.com/repos/pydata/xarray/issues/668 162031347 MDEyOklzc3VlQ29tbWVudDE2MjAzMTM0Nw== 1217238 2015-12-04T17:40:47Z 2015-12-04T17:40:47Z MEMBER

How did pandas land on this. To me it makes more sense as an argument to init but I'll go with whatever pandas decided for consistency.

Still unresolved, though Jeff Reback agrees with you. It's being discussed in the rolling PR currently.

Also: what about changing the default min_count to 0? I think that would be more consistent with pandas, which skips over missing values by default.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  120038291
Powered by Datasette · Queries took 0.438ms · About: xarray-datasette