home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 161782889

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/668#issuecomment-161782889 https://api.github.com/repos/pydata/xarray/issues/668 161782889 MDEyOklzc3VlQ29tbWVudDE2MTc4Mjg4OQ== 1217238 2015-12-03T20:59:28Z 2015-12-03T20:59:28Z MEMBER

How do you suggest we handle the bottleneck dependency? That is the reason for the failing tests at the moment.

You can either add a try/except around a top level import of bottleneck, or only import bottleneck locally inside functions which need it. I think I would prefer the later approach because it results in more intelligible error messages (ImportError: No module named bottleneck rather than NameError: name 'bottleneck' is not defined).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  120038291
Powered by Datasette · Queries took 0.791ms · About: xarray-datasette